[PhpUnitBridge] Don't use die() in PHPT --SKIPIF--#58680
Conversation
Unlocks a performance optimization in PHPUnit 11.x see https://staabm.github.io/2024/10/19/phpunit-codesprint-munich.html
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
//cc @xabbuh |
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.2 for features / 5.4, 6.4, and 7.1 for bug fixes". Cheers! Carsonbot |
die() in PHPT --SKIPIF--die() in PHPT --SKIPIF--
|
@staabm FYI, with these changes our phpt tests are about 9% faster than without them |
|
Awesome, thanks for reporting back. |
|
Thank you @staabm. |
Unlocks a performance optimization in PHPUnit 11.5.x
PHPUnit 11.5.x will be able to avoid subprocess creation, when
--SKIPIF--code in PHPT tests does notexit()ordie()and the logic is side-effect free (output is allowed).more details in https://staabm.github.io/2024/10/19/phpunit-codesprint-munich.html