Skip to content

[TwigBridge] Remove usage of Node() instantiations#58404

Merged
fabpot merged 1 commit into
symfony:5.4from
fabpot:twig-node-abstract
Sep 27, 2024
Merged

[TwigBridge] Remove usage of Node() instantiations#58404
fabpot merged 1 commit into
symfony:5.4from
fabpot:twig-node-abstract

Conversation

@fabpot

@fabpot fabpot commented Sep 26, 2024

Copy link
Copy Markdown
Member
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues n/a
License MIT

See twigphp/Twig#4335 (which should be merged first)

@fabpot fabpot requested a review from xabbuh as a code owner September 26, 2024 19:27
@carsonbot carsonbot added this to the 7.2 milestone Sep 26, 2024
@fabpot fabpot changed the base branch from 7.2 to 5.4 September 26, 2024 19:27
@fabpot fabpot modified the milestones: 7.2, 5.4 Sep 26, 2024
@symfony symfony deleted a comment from carsonbot Sep 26, 2024
@OskarStark OskarStark changed the title [TwigBridge] Remove usage of Node() instantiations [TwigBridge] Remove usage of Node() instantiations Sep 27, 2024
@xabbuh

xabbuh commented Sep 27, 2024

Copy link
Copy Markdown
Member

@fabpot Can you please rebase to trigger the pipeline?

@fabpot

fabpot commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

@fabpot Can you please rebase to trigger the pipeline?

Done

Comment thread src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php Outdated
@fabpot fabpot merged commit 459590d into symfony:5.4 Sep 27, 2024
@fabpot fabpot deleted the twig-node-abstract branch September 27, 2024 18:55
This was referenced Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants