Switch to ExpectUserDeprecationMessageTrait#58314
Conversation
|
Please work first on making this a proper polyfill before migrating to it (so that you don't hide cases where the test would pass only because of the non-standard behavior of the polyfill). See the discussion on the PR adding that trait. |
|
This is not a blocker. We already have migrated to the new polyfill. This PR merely fixes an inconsistency and the polyfill works good enough for our tests. |
|
@derrabus the polyfill works for our tests because it behaves like |
|
Well, we make zero use of that fuzzy matching feature, so the behavior is the same for our tests. You're right that we need to fix the polyfill, but it's not a blocker for this PR. |
|
But here you go: #58317 |
4333bed to
d923c28
Compare
This PR switches some tests added after #54593 to our new trait, allowing us to run those under PHPUnit 11 as well.