Skip to content

[TypeInfo] Return bound type as base type in TemplateType#58259

Merged
fabpot merged 1 commit intosymfony:7.1from
valtzu:serializer-generics-template-fix-v2
Sep 18, 2024
Merged

[TypeInfo] Return bound type as base type in TemplateType#58259
fabpot merged 1 commit intosymfony:7.1from
valtzu:serializer-generics-template-fix-v2

Conversation

@valtzu
Copy link
Copy Markdown
Contributor

@valtzu valtzu commented Sep 13, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58031
License MIT

This supersedes #58033 as simpler approach.

@carsonbot
Copy link
Copy Markdown

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link
Copy Markdown
Contributor

@mtarld mtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@valtzu valtzu force-pushed the serializer-generics-template-fix-v2 branch from 8d50547 to f897a7b Compare September 16, 2024 16:19
@fabpot fabpot modified the milestones: 7.2, 7.1 Sep 18, 2024
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Sep 18, 2024

Thank you @valtzu.

@fabpot fabpot merged commit bd3a256 into symfony:7.1 Sep 18, 2024
@fabpot fabpot mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception deserializing class with generic property

5 participants