[Serializer] Fix for method named get()#58226
Merged
nicolas-grekas merged 1 commit intosymfony:6.4from Sep 16, 2024
mihai-stancu:bugfix/serializer-fails-on-method-named-get
Merged
[Serializer] Fix for method named get()#58226nicolas-grekas merged 1 commit intosymfony:6.4from mihai-stancu:bugfix/serializer-fails-on-method-named-get
get()#58226nicolas-grekas merged 1 commit intosymfony:6.4from
mihai-stancu:bugfix/serializer-fails-on-method-named-get
Conversation
Contributor
Author
|
I'll add a test for this tomorrow. |
get()
Comment on lines
+103
to
+105
| if ($name !== 'get' && str_starts_with($name, 'get') | ||
| || $name !== 'has' && str_starts_with($name, 'has') | ||
| || $name !== 'can' && str_starts_with($name, 'can')) { |
Member
There was a problem hiding this comment.
Suggested change
| if ($name !== 'get' && str_starts_with($name, 'get') | |
| || $name !== 'has' && str_starts_with($name, 'has') | |
| || $name !== 'can' && str_starts_with($name, 'can')) { | |
| if (3 < \strlen($name) && (...)) { |
src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
Outdated
Show resolved
Hide resolved
dunglas
reviewed
Sep 11, 2024
src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
Outdated
Show resolved
Hide resolved
Member
|
Thank you @mihai-stancu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During normalization, if a class has a method called
getthat method will get confused for an accessor and it will go through logic relating to property-access for the property namedsubstr('get', 3).Eventually a new PropertyPath instance will be created with an empty path which will trigger an exception.