[AssetMapper] Add "=alias" syntax to importmap:require#50445
Merged
fabpot merged 1 commit intosymfony:6.3from May 26, 2023
Merged
[AssetMapper] Add "=alias" syntax to importmap:require#50445fabpot merged 1 commit intosymfony:6.3from
fabpot merged 1 commit intosymfony:6.3from
Conversation
fabpot
approved these changes
May 26, 2023
Member
|
Thank you @weaverryan. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing final testing against all of the UX packages. There is one edge-case where we need to require a specific package path -
vue/dist/vue.esm-bundler.js- but alias it (i.e. make its key) set to something else -vue- inimportmap.php. We need the command to support this so that symfony/flex#975 can use it when installing UX packages.Hopefully the last thing I come across - I've done a LOT of testing at this point.
Thanks!