[Console] trim(): Argument #1 () must be of type string, bool given#50143
Merged
chalasr merged 1 commit intosymfony:5.4from Apr 25, 2023
Merged
[Console] trim(): Argument #1 () must be of type string, bool given#50143chalasr merged 1 commit intosymfony:5.4from
chalasr merged 1 commit intosymfony:5.4from
Conversation
derrabus
approved these changes
Apr 24, 2023
stof
approved these changes
Apr 25, 2023
chalasr
approved these changes
Apr 25, 2023
Member
|
Thank you @danepowell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run a Symfony Console application in Git Bash, ANSICON is not set out of the box and results in this (suppressed) error:
AFAICT, this method is only called from Application::run() and errors are suppressed. So users will never actually see that error. Still, it could have side effects and breaks downstream projects: box-project/box#990