Skip to content

[VarDumper] Fix error when reflected class has default Enum parameter in constructor#49292

Merged
nicolas-grekas merged 1 commit intosymfony:5.4from
kapiwko:patch-1
Feb 23, 2023
Merged

[VarDumper] Fix error when reflected class has default Enum parameter in constructor#49292
nicolas-grekas merged 1 commit intosymfony:5.4from
kapiwko:patch-1

Conversation

@kapiwko
Copy link
Copy Markdown
Contributor

@kapiwko kapiwko commented Feb 8, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Have classes:

enum GeometryType: string
{
    case Geometry = 'GEOMETRY';
}

final class Geometry
{
    public function __construct(GeometryType $type = GeometryType::Geometry)
    {
    }
}

Try to dump reflection of class Geometry:

$reflection = new \ReflectionClass(Geometry::class);
dump($reflection);

Have error:
Symfony\Component\VarDumper\Caster\ConstStub::__construct(): Argument #2 ($value) must be of type string|int|float|null, App\Infrastructure\Geometry\GeometryType given, called in [...]/vendor/symfony/var-dumper/Caster/ReflectionCaster.php on line 296

@carsonbot carsonbot added this to the 6.3 milestone Feb 8, 2023
@carsonbot
Copy link
Copy Markdown

carsonbot commented Feb 8, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link
Copy Markdown

carsonbot commented Feb 8, 2023

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Feb 8, 2023
View reviewed changes
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 5.4 Feb 23, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.3 to 5.4 February 23, 2023 10:00
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Feb 23, 2023

Thank you @kapiwko.

@nicolas-grekas nicolas-grekas merged commit 2a633cf into symfony:5.4 Feb 23, 2023
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

No one assigned

Labels

Bug Status: Needs Review VarDumper

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@kapiwko @carsonbot @nicolas-grekas