Skip to content

[Serializer] Add support of true built-in type (from PHP 8.2)#46675

Merged
nicolas-grekas merged 1 commit intosymfony:6.2from
alexandre-daubois:fix-true-builtin-type
Jun 20, 2022
Merged

[Serializer] Add support of true built-in type (from PHP 8.2)#46675
nicolas-grekas merged 1 commit intosymfony:6.2from
alexandre-daubois:fix-true-builtin-type

Conversation

@alexandre-daubois
Copy link
Copy Markdown
Member

@alexandre-daubois alexandre-daubois commented Jun 15, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

RFC: https://wiki.php.net/rfc/true-type
Pull request: php/php-src#8326

Same as this PR to add support of false and null types: #45981

@carsonbot carsonbot added this to the 4.4 milestone Jun 15, 2022
@carsonbot carsonbot changed the title [Serializer][PropertyInfo] Add support of true built-in type (from PHP 8.2) [PropertyInfo][Serializer] Add support of true built-in type (from PHP 8.2) Jun 15, 2022
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jun 17, 2022

That's a new feature that should be part of 6.2. Merging #45981 in 4.4 was a mistake.
I'm all for making 4.4 compatible with 8.2 because the code should work well with 8.2, but adding new features is a no-go for me.
If one wants to use newer PHP features, they need to update to the latest Symfony version; I think it makes sense.

@alexandre-daubois
Copy link
Copy Markdown
Member Author

alexandre-daubois commented Jun 17, 2022 •
edited
Loading

Thank you for the feedback @fabpot! I understand and agree your point of view on new PHP features. I'll do the necessary changes (if any) and rebase this to 6.2 👍

@alexandre-daubois alexandre-daubois changed the base branch from 4.4 to 6.2 June 17, 2022 08:15
@alexandre-daubois alexandre-daubois force-pushed the fix-true-builtin-type branch 2 times, most recently from 0608808 to c3dafbd Compare June 17, 2022 08:17
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 6.2 Jun 19, 2022
@carsonbot carsonbot changed the title [PropertyInfo][Serializer] Add support of true built-in type (from PHP 8.2) [Serializer] Add support of true built-in type (from PHP 8.2) Jun 20, 2022
@nicolas-grekas nicolas-grekas force-pushed the fix-true-builtin-type branch from c3dafbd to 2ec0453 Compare June 20, 2022 12:22
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Jun 20, 2022

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 1ded85f into symfony:6.2 Jun 20, 2022
@alexandre-daubois alexandre-daubois deleted the fix-true-builtin-type branch June 20, 2022 12:26
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@derrabus derrabus Awaiting requested review from derrabus

+1 more reviewer

@maxhelias maxhelias maxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Serializer Status: Needs Review

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

8 participants

@alexandre-daubois @fabpot @nicolas-grekas @dunglas @derrabus @mtarld @maxhelias @carsonbot