Skip to content

[HttpFoundation] Fix PHP 8.1 deprecation in Response::isNotModified#45631

Merged
fabpot merged 1 commit intosymfony:4.4from
HypeMC:php-8.1-deprecation-in-isnotmodified
Mar 4, 2022
Merged

[HttpFoundation] Fix PHP 8.1 deprecation in Response::isNotModified#45631
fabpot merged 1 commit intosymfony:4.4from
HypeMC:php-8.1-deprecation-in-isnotmodified

Conversation

@HypeMC
Copy link
Copy Markdown
Member

@HypeMC HypeMC commented Mar 4, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

If an If-None-Match header is provided in the request and there's no ETag header in the response, the following deprecation notice occurs on PHP 8.1 in Response::isNotModified:

Deprecated: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated

@carsonbot carsonbot added this to the 4.4 milestone Mar 4, 2022
@HypeMC HypeMC force-pushed the php-8.1-deprecation-in-isnotmodified branch from e436f1d to e09c579 Compare March 4, 2022 06:22
@HypeMC HypeMC force-pushed the php-8.1-deprecation-in-isnotmodified branch from e09c579 to b909acf Compare March 4, 2022 06:25
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Mar 4, 2022

Thank you @HypeMC.

@fabpot fabpot merged commit 3cea8e7 into symfony:4.4 Mar 4, 2022
@HypeMC HypeMC deleted the php-8.1-deprecation-in-isnotmodified branch March 4, 2022 07:16
This was referenced Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants