[Process] Avoid calling fclose on an already closed resource#45103
Merged
nicolas-grekas merged 1 commit intosymfony:4.4from Jan 24, 2022
Merged
[Process] Avoid calling fclose on an already closed resource#45103nicolas-grekas merged 1 commit intosymfony:4.4from
nicolas-grekas merged 1 commit intosymfony:4.4from
Conversation
| @@ -47,7 +47,9 @@ public function __construct($input) | |||
| public function close() | |||
| { | |||
| foreach ($this->pipes as $pipe) { | |||
Member
There was a problem hiding this comment.
let's remove the foreach completly, php will cleanup handles automatically
Member
Author
There was a problem hiding this comment.
Not removing foreach completely then?
Member
There was a problem hiding this comment.
not being too smart is usually safer :P
c45c8cd to
a9e43a7
Compare
Member
|
Thank you @Seldaek. |
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got this in Composer while interrupting an install process with Ctrl-C.
I am assuming it's due to a process which was not closed properly, which is very likely given we run a bunch of them concurrently.. It's pretty hard to debug as it's also hard to reproduce, so I am not sure what to do except handle this case gracefully in the close/__destruct function and hope that at least lets it clean up processes without crashing this way.