[Serializer] Fix AbstractObjectNormalizer TypeError on denormalization#44908
Merged
fancyweb merged 1 commit intosymfony:6.0from Jan 12, 2022
JustDylan23:ticket_44872
Merged
[Serializer] Fix AbstractObjectNormalizer TypeError on denormalization#44908fancyweb merged 1 commit intosymfony:6.0from JustDylan23:ticket_44872
fancyweb merged 1 commit intosymfony:6.0from
JustDylan23:ticket_44872
Conversation
|
Hey! I think @Th3Mouk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Contributor
|
It would still makes more sense to me if the test was in |
fancyweb
approved these changes
Jan 7, 2022
Contributor
Author
I moved it 👍 |
Contributor
Author
|
are the tests that are failing now something on my end? I could rebase on 6.0 if desired |
Contributor
|
Thanks. The tests look good to me. |
dunglas
approved these changes
Jan 12, 2022
Contributor
|
Thank you @JustDylan23. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using dependency injection to get the serializer (instead of manually instantiating it) the object normalizer that is injected into that serializer throws a value exception when doing denormalizing the following:
This throws
Refer to: #44881 for the description.
Was in the middle of changing the base branch and accidentally pushed when the branch was deleted.
@fancyweb I implemented the requested changes