Skip to content

[Notifier] Use correct factory for the msteams transport#44771

Merged
fabpot merged 1 commit intosymfony:5.3from
veewee:5.3-teams-notifier
Dec 23, 2021
Merged

[Notifier] Use correct factory for the msteams transport#44771
fabpot merged 1 commit intosymfony:5.3from
veewee:5.3-teams-notifier

Conversation

@veewee
Copy link
Copy Markdown
Contributor

@veewee veewee commented Dec 23, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Creating a microsoft teams transport through the Notifier Transport::fromDsn() class results in an exception:

PHP Fatal error:  Uncaught TypeError: Symfony\Component\Notifier\Bridge\MicrosoftTeams\MicrosoftTeamsTransport::__construct(): Argument #1 ($path) must be of type string, null given, called in /vendor/symfony/notifier/Transport.php on line 186 and defined in /vendor/symfony/microsoft-teams-notifier/MicrosoftTeamsTransport.php:35
Stack trace:

* snap *

This PR uses the correct ms teams transport factory instead.
It is pointed at the 5.3 branch, in which this specific transport was introduced.
The error is also there in all versions upwards. See https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/Notifier/Transport.php#L84

@veewee veewee requested a review from OskarStark as a code owner December 23, 2021 12:16
@carsonbot carsonbot added this to the 5.3 milestone Dec 23, 2021
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Dec 23, 2021

Thank you @veewee.

@fabpot fabpot merged commit 908b21f into symfony:5.3 Dec 23, 2021
@OskarStark
Copy link
Copy Markdown
Contributor

OskarStark commented Dec 23, 2021

Good catch, thank you 🙏

This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees

No one assigned

Labels

Bug Notifier Status: Reviewed

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@veewee @fabpot @OskarStark @carsonbot