Skip to content

[DependencyInjection] Cast tag attribute value to string#44639

Merged
fabpot merged 1 commit intosymfony:4.4from
ruudk:set-attribute-nullable-php-81
Dec 17, 2021
Merged

[DependencyInjection] Cast tag attribute value to string#44639
fabpot merged 1 commit intosymfony:4.4from
ruudk:set-attribute-nullable-php-81

Conversation

@ruudk
Copy link
Copy Markdown
Contributor

@ruudk ruudk commented Dec 15, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR
DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated

This happens when a tag value is null on PHP 8.1.

@carsonbot carsonbot added this to the 4.4 milestone Dec 15, 2021
@carsonbot carsonbot changed the title [DependencyInjection][PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated [DependencyInjection] [PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated Dec 15, 2021
@ruudk ruudk force-pushed the set-attribute-nullable-php-81 branch from 59c0a3d to 26e56fb Compare December 15, 2021 11:58
Comment thread src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php Outdated
DOMElement::setAttribute(): Passing null to parameter symfony#2 ($value) of type string is deprecated

This happens when a tag value is `null` on PHP 8.1.
@ruudk ruudk force-pushed the set-attribute-nullable-php-81 branch from 26e56fb to 8fe5fce Compare December 15, 2021 12:10
@derrabus derrabus changed the title [DependencyInjection] [PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated [DependencyInjection] Cast tag attribute value to string Dec 15, 2021
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Dec 17, 2021

Thank you @ruudk.

@fabpot fabpot merged commit f2cac74 into symfony:4.4 Dec 17, 2021
@ruudk ruudk deleted the set-attribute-nullable-php-81 branch December 17, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants