Skip to content

Missing queue_name parameter in Doctrine Transport#40588

Closed
monteiro wants to merge 2 commits intosymfony:5.2from
monteiro:fix-queue-name-missing-doctrine-mess
Closed

Missing queue_name parameter in Doctrine Transport#40588
monteiro wants to merge 2 commits intosymfony:5.2from
monteiro:fix-queue-name-missing-doctrine-mess

Conversation

@monteiro
Copy link
Copy Markdown
Contributor

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This bug was noticed by @weaverryan when reviewing the PR: #38468 related to multiple failure transports.

@monteiro monteiro requested a review from sroze as a code owner March 25, 2021 18:04
@carsonbot carsonbot added this to the 5.2 milestone Mar 25, 2021
@nicolas-grekas
Copy link
Copy Markdown
Member

Can you add a test case please?

@monteiro
Copy link
Copy Markdown
Contributor Author

monteiro commented Mar 26, 2021

Going to close this PR, because after talking with @weaverryan , the best branch for this is 4.4, not 5.2 so we also fix this in the LTS. I will create a new PR with the 4.4.

@monteiro monteiro closed this Mar 26, 2021
@monteiro monteiro deleted the fix-queue-name-missing-doctrine-mess branch March 26, 2021 10:05
@monteiro
Copy link
Copy Markdown
Contributor Author

Created this one #40595 agaisn't 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants