[FrameworkBundle] Add KernelTestCase::getContainer()#40366
Merged
fabpot merged 1 commit intosymfony:5.xfrom Mar 12, 2021
Merged
[FrameworkBundle] Add KernelTestCase::getContainer()#40366fabpot merged 1 commit intosymfony:5.xfrom
fabpot merged 1 commit intosymfony:5.xfrom
Conversation
OskarStark
reviewed
Mar 4, 2021
ro0NL
reviewed
Mar 6, 2021
ro0NL
reviewed
Mar 6, 2021
wouterj
requested changes
Mar 9, 2021
Member
wouterj
left a comment
There was a problem hiding this comment.
At first I thought: Oh no. But I think this makes sense: you'll get a friendly error (instead of a completely different container) and no more "you'll have to boot the kernel first".
Sorry for the complete nitpicking on anything that wasn't PHP code in this review 🙈
Member
Author
|
Thank you for the review. I've updated the PR according to your suggestions. |
wouterj
approved these changes
Mar 9, 2021
fabpot
approved these changes
Mar 12, 2021
Member
|
Thank you @Nyholm. |
Member
Author
|
Thank you for merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are at least 3 ways to get the container in a test class:
I suggest to add a fourth =)
Basically, in tests you should always use the
test.service_container. It is hard to remove A and C, but I can deprecate C and add a helper function.This new way will also boot your kernel if it is not already booted.