[Console] Add input argument getters with typehint#39110
Closed
noniagriconomie wants to merge 1 commit intosymfony:5.xfrom
Closed
[Console] Add input argument getters with typehint#39110noniagriconomie wants to merge 1 commit intosymfony:5.xfrom
noniagriconomie wants to merge 1 commit intosymfony:5.xfrom
Conversation
derrabus
requested changes
Nov 18, 2020
Member
derrabus
left a comment
There was a problem hiding this comment.
I don't see much value in this change. If you want to apply a type cast on the result of getArgument() you can already do so in userland. There's no need to hide that cast behind a method.
Contributor
Author
|
@derrabus indeed, i was think that at first but then i remembered the request param bag logic thx for stopping here :) |
Member
|
The parameter bag on the request does a little bit more than a type cast. Sorry, but I don‘t think we should implement these methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mimic https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/HttpFoundation/ParameterBag.php#L159
It can help write commands with proper args typehints like when dealing with request args via the parameterbag
I do not know if this was proposed before, thus feel free to close