Skip to content

[Console] Make sure we pass a numeric array of arguments to call_user_func_array()#37774

Merged
fabpot merged 1 commit intosymfony:3.4from
derrabus:bugfix/variadic-array-merge
Aug 9, 2020
Merged

[Console] Make sure we pass a numeric array of arguments to call_user_func_array()#37774
fabpot merged 1 commit intosymfony:3.4from
derrabus:bugfix/variadic-array-merge

Conversation

@derrabus
Copy link
Copy Markdown
Member

@derrabus derrabus commented Aug 8, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

On php 8, the unit tests fail with the following error:

ArgumentCountError: array_merge() does not accept unknown named parameters

This PR should fix the issue.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Aug 9, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 83b1d71 into symfony:3.4 Aug 9, 2020
@derrabus derrabus deleted the bugfix/variadic-array-merge branch August 9, 2020 08:32
This was referenced Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants