[VarDumper] Improve previous fix on light array coloration#37700
Merged
fabpot merged 1 commit intosymfony:3.4from Jul 31, 2020
Merged
[VarDumper] Improve previous fix on light array coloration#37700fabpot merged 1 commit intosymfony:3.4from
fabpot merged 1 commit intosymfony:3.4from
Conversation
Member
|
Thanks for the patch. Can you please target 3.4 since that was the target of #36230? |
1080cc4 to
8a075f4
Compare
8a075f4 to
cef16f5
Compare
Contributor
Author
|
Indeed 🙂 Target branch updated |
fabpot
approved these changes
Jul 31, 2020
Member
|
Thank you @l-vo. |
This was referenced Aug 31, 2020
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve #36230 to fix #37674 (revert previous fix and use a solution that looks better).