Skip to content

[DI] Fix call to sprintf in ServicesConfigurator::stack()#37396

Merged
fabpot merged 1 commit intosymfony:5.1from
dunglas:fix/servicesconfigurator-stack
Jun 23, 2020
Merged

[DI] Fix call to sprintf in ServicesConfigurator::stack()#37396
fabpot merged 1 commit intosymfony:5.1from
dunglas:fix/servicesconfigurator-stack

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented Jun 23, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This PR fixes a faulty call to sprintf() and prevents the following error:

Warning: sprintf(): Too few arguments in /Users/dunglas/workspace/activity-pub/vendor/symfony/dependency-injection/Loader/Configurator/ServicesConfigurator.php on line 154

Fatal error: Uncaught Error: Wrong parameters for Symfony\Component\DependencyInjection\Exception\InvalidArgumentException([string $message [, long $code [, Throwable $previous = NULL]]]) in /Users/dunglas/workspace/activity-pub/vendor/symfony/dependency-injection/Loader/Configurator/ServicesConfigurator.php:154 Stack trace: #0 /Users/dunglas/workspace/activity-pub/vendor/symfony/dependency-injection/Loader/Configurator/ServicesConfigurator.php(154): Exception->__construct('', 1, 'api_platform.js...') #1 /Users/dunglas/workspace/activity-pub/src/Bundle/Resources/config/services.php(12): Symfony\Component\DependencyInjection\Loader\Configurator\ServicesConfigurator->stack('api_platform.js...', Array) #2 /Users/dunglas/workspace/activity-pub/vendor/symfony/dependency-injection/Loader/PhpFileLoader.php(50): Symfony\Component\DependencyInjection\Loader\ProtectedPhpFileLoader::Symfony\Component\DependencyInjection\Loader\Configurator\{closure}(Object(Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurat in /Users/dunglas/workspace/activity-pub/vendor/symfony/dependency-injection/Loader/Configurator/ServicesConfigurator.php on line 154

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Jun 23, 2020
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jun 23, 2020

Thank you @dunglas.

@fabpot fabpot merged commit 51a1820 into symfony:5.1 Jun 23, 2020
@fabpot fabpot mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

No one assigned

Labels

Bug DependencyInjection Status: Reviewed

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dunglas @fabpot @nicolas-grekas @carsonbot