[WebProfilerBundle] Fix error with custom function and web profiler routing tab#37102
Merged
fabpot merged 1 commit intosymfony:4.4from Jul 31, 2020
JakeFr:custom_function_route
Merged
[WebProfilerBundle] Fix error with custom function and web profiler routing tab#37102fabpot merged 1 commit intosymfony:4.4from JakeFr:custom_function_route
fabpot merged 1 commit intosymfony:4.4from
JakeFr:custom_function_route
Conversation
JakeFr
commented
Jun 4, 2020
| */ | ||
| private $expressionLanguageProviders = []; | ||
|
|
||
| public function __construct(Profiler $profiler = null, Environment $twig, UrlMatcherInterface $matcher = null, iterable $expressionLanguageProviders = [], RouteCollection $routes = null) |
Contributor
Author
There was a problem hiding this comment.
I can find where/when the $routes argument is set. So i add the new one just befrore
Member
There was a problem hiding this comment.
please add it last, that's a BC break otherwise
Contributor
Author
There was a problem hiding this comment.
How do I define argument "$routes" in profiler.xml ?
Contributor
Author
There was a problem hiding this comment.
I declare routes explicitly to null
fabpot
approved these changes
Jul 31, 2020
Member
|
Thank you @JakeFr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a simple solution for #36985 as it only concerns WebProfilerBundle.
Due to the limitation in the routing tab as explained in the footnote, the route in my repo did not match in profiler (no query string in the new context) but there is no more syntax error.