Remove patches for Doctrine bugs and deprecations#36744
Merged
nicolas-grekas merged 1 commit intosymfony:3.4from May 8, 2020
Merged
Remove patches for Doctrine bugs and deprecations#36744nicolas-grekas merged 1 commit intosymfony:3.4from
nicolas-grekas merged 1 commit intosymfony:3.4from
Conversation
Contributor
Author
|
This is safe to merge iff not using doctrine/orm >=2.8.x in a pipeline, as this was not merged up yet. Maybe that's what you do on other branches, I'm not sure. Otherwise, let's just wait for these PRs to bubble up in ORM (I can work on speeding that up if necessary) |
d2828d4 to
2f305cd
Compare
Member
|
Thank you @greg0ire. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes patches put in place because of a bug fixed in doctrine/dbal#3994, and because of deprecations addressed in doctrine/orm#7953