Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.43
Choose a base ref
...
head repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.44
Choose a head ref
  • 7 commits
  • 15 files changed
  • 5 contributors

Commits on Jun 27, 2022

  1. CS fixes

    @nicolas-grekas
    nicolas-grekas committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    19b8d53 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Fix tests that use deprecated callable syntax

    @derrabus
    derrabus committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    2cd0a03 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. [FrameworkBundle] Fail gracefully when forms use disabled CSRF

    @HeahDude
    HeahDude committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    3a8bfb3 View commit details
    Browse the repository at this point in the history

  2. bug #46960 [FrameworkBundle] Fail gracefully when forms use disabled … 

    …CSRF (HeahDude)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fail gracefully when forms use disabled CSRF

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | kind of
| New feature?  | no
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Relates to symfony/symfony-docs#16973.

Currently with the following config in Symfony demo:
```yaml
# config/packages/framework.yaml
framework:
    csrf_protection: false
    form:
        csrf_protection: true
```
we get:
>The service "form.type_extension.csrf" has a dependency on a non-existent service "security.csrf.token_manager".

We should consider this PR as a bug fix to make this exception actionable.

Commits
-------

5990182698 [FrameworkBundle] Fail gracefully when forms use disabled CSRF
    @fabpot
    fabpot committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    9707186 View commit details
    Browse the repository at this point in the history

  3. Fix CS

    @fabpot
    fabpot committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    d214b0b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. fix expected exception message assertion

    @xabbuh
    xabbuh committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    a647d42 View commit details
    Browse the repository at this point in the history

  2. Fix CS

    @fabpot
    fabpot committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    3cbca8f View commit details
    Browse the repository at this point in the history
Loading