AssetMapper: upgrade packages when needed#996
Merged
fabpot merged 1 commit intosymfony:1.xfrom Oct 22, 2023
Merged
Conversation
Contributor
Author
|
fabbot failures are incorrect - they're trying to add PHP 8 only functions, while 1.x works on 7.1. |
fabpot
approved these changes
Oct 22, 2023
4376a14 to
5214615
Compare
Member
|
Thank you @weaverryan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
The scenario:
symfony/ux-autocomplete. Flex addstom-selectat version2.2.3toimportmap.phpsymfony/ux-autocomplete. The new version now requirestom-selectat^2.5.If we do nothing, the user's
tom-selectis out of date and the user won't even know about it. The^2.5constraint is defined in thesymfony/ux-autocompletepackage.json file, but nothing enforces that or notifies the user.With this small change, during a composer update/require, we look at the dependencies of all UX packages and compare them against the version in
importmap.php. If they do not match, the package is upgraded to a version that matches.We're not creating a fully-fledge package management by any means, but we don't need to. With a few notifications and things like this, we can keep the user's dependencies in sync with each other.
Unrelated: don't forget about that really cool other PR #978 ;)
Cheers!