Keep existing constraints in package.json#965
Merged
nicolas-grekas merged 1 commit intosymfony:1.xfrom Jan 30, 2023
Merged
Conversation
maxhelias
reviewed
Jan 23, 2023
maxhelias
previously approved these changes
Jan 23, 2023
weaverryan
reviewed
Jan 23, 2023
Contributor
weaverryan
left a comment
There was a problem hiding this comment.
😍
I've just made a small suggestion so that the test case will cover BOTH situations (when a constraint should not be updated but also when it SHOULD be updated). I've tested things locally, including these test changes. It's all working awesomely!
Thanks @smnandre!
Member
Author
|
Thank you both for your review and your suggestions 😃 |
weaverryan
previously approved these changes
Jan 23, 2023
Contributor
weaverryan
left a comment
There was a problem hiding this comment.
This is ready to go - excellent work - it seems to work great when I played with the test locally!
The base branch was changed.
b4bbd2c to
ae95fe1
Compare
Member
|
Thank you @smnandre. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dependency constraint is already set in the package.json, the PackageSynchroniser replaces it with even if the constraint is valid.
This PR changes this behaviour and let the constraint untouched if it matches the one provided by the PHP package.
Related issues: