Add configurator for "composer-commands" entries in recipes#930
Merged
nicolas-grekas merged 1 commit intosymfony:2.xfrom May 20, 2025
Merged
Add configurator for "composer-commands" entries in recipes#930nicolas-grekas merged 1 commit intosymfony:2.xfrom
nicolas-grekas merged 1 commit intosymfony:2.xfrom
Conversation
Contributor
Author
|
I will fix the build "PHP 7.4 low-deps" at weekend. |
3bc44a3 to
ad92e20
Compare
maxhelias
approved these changes
Jan 23, 2023
alamirault
approved these changes
Oct 26, 2023
alamirault
left a comment
There was a problem hiding this comment.
Thanks for the PR, I also need to add commands to script section. I hope it can be merged.
README should probably be updated to document the nex configurator (In another PR ?)
ad92e20 to
92d9551
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM thanks! Sorry for the late review. I rebase to 2.x
nicolas-grekas
approved these changes
May 20, 2025
92d9551 to
fc715ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #901
At the moment in recipe we can use
composer-scripts, but those commands will be running only duringcomposer installorcomposer update.This PR adds a new configuration option
composer-commands.We can add to recipe:
and flex will add to
composer.jsonnecessary entry and we will able to callcomposer run commandto executevendor/bin/foo.This behavior is very similar to current Makefile configurator as mentioned in #901.