Shorten Symfony Recipe URL Cache Keys#831
Merged
nicolas-grekas merged 1 commit intosymfony:1.xfrom Nov 22, 2021
Merged
Conversation
Author
|
The failing tests appear to be due to an API change in Composer, unrelated to my code changes. Should I fix these? $realPkg = new Package('real', '1.0.0', '1.0.0');
$realPkgLink = new Link('lorem', 'real', class_exists(MatchAllConstraint::class) ? new MatchAllConstraint() : null, 'wraps', '1.0.0');
$virtualPkgFoo = new Package('pack_foo', '1.0.0', '1.0.0');
$virtualPkgFoo->setType('symfony-pack');
$virtualPkgFoo->setRequires([$realPkgLink]); $realPkg = new Package('real', '1.0.0', '1.0.0');
$realPkgLink = new Link('lorem', 'real', class_exists(MatchAllConstraint::class) ? new MatchAllConstraint() : null, 'wraps', '1.0.0');
$virtualPkgFoo = new Package('pack_foo', '1.0.0', '1.0.0');
$virtualPkgFoo->setType('symfony-pack');
$virtualPkgFoo->setRequires(['real' => $realPkgLink]); |
jderusse
reviewed
Nov 22, 2021
Member
|
Thank you @cjunge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #830.
This change replaces the simple generated composer filesystem cache key with a slightly shorter one only for the Symfony Recipes repos.
/home/cameron/.cache/composer/repo/flex/https---api.github.com-repos-symfony-recipes-contrib-contents-friendsofsymfony.elastica-bundle.5.0.json-ref-flex-mainbecomes
/home/cameron/.cache/composer/repo/flex/sf-recipes-contrib-friendsofsymfony.elastica-bundle.5.0.json-ref-flex-mainThis won't fix other recipe files hosted on long paths.