Skip to content

Fix copy from package with directories#756

Merged
nicolas-grekas merged 1 commit intosymfony:mainfrom
mnocon:fix-copy-from-package-with-directories
May 14, 2021
Merged

Fix copy from package with directories#756
nicolas-grekas merged 1 commit intosymfony:mainfrom
mnocon:fix-copy-from-package-with-directories

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Apr 23, 2021

Potential fix for #755

I've:

  1. added a test that uncovers the issue - even when force is used the existing files are not overwritten
  2. added a test that makes sure the behaviour does not change when force is not used
  3. fixed the issue by respecting the force option in copyDir method.

@nicolas-grekas
Copy link
Copy Markdown
Member

Thank you @mnocon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants