Skip to content

Don't remove still-referenced files when updating recipes#1057

Merged
fabpot merged 1 commit intosymfony:2.xfrom
wouterj:detect-file-removals-during-update
Aug 22, 2025
Merged

Don't remove still-referenced files when updating recipes#1057
fabpot merged 1 commit intosymfony:2.xfrom
wouterj:detect-file-removals-during-update

Conversation

@wouterj
Copy link
Copy Markdown
Member

@wouterj wouterj commented May 30, 2025

A twin to #1054

When a recipe removes a file in a newer recipe version, we should also check if other recipes still reference that file.

Real use-case: This occurs when you need to keep the PhpunitBridge in 7.3 (e.g. you need the clock mock).

Comment thread src/Update/RecipePatcher.php
@wouterj wouterj force-pushed the detect-file-removals-during-update branch from b77d805 to 03ac318 Compare July 5, 2025 12:55
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Aug 22, 2025

Thank you @wouterj.

@fabpot fabpot merged commit f356aa3 into symfony:2.x Aug 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants