feat: add ability to skip package.json synchronization#1032
Merged
fabpot merged 1 commit intosymfony:1.xfrom Mar 3, 2025
Merged
feat: add ability to skip package.json synchronization#1032fabpot merged 1 commit intosymfony:1.xfrom
fabpot merged 1 commit intosymfony:1.xfrom
Conversation
9b8e4cb to
6a726fa
Compare
skmedix
reviewed
Dec 10, 2024
Contributor
skmedix
left a comment
There was a problem hiding this comment.
Perhaps it would be better if it logs what exactly has been skipped?
Contributor
Author
@skmedix Currently it already outputs this |
dmaicher
approved these changes
Feb 5, 2025
Contributor
dmaicher
left a comment
There was a problem hiding this comment.
I also need this option 👍
94noni
approved these changes
Feb 7, 2025
skmedix
approved these changes
Feb 9, 2025
Contributor
skmedix
left a comment
There was a problem hiding this comment.
I think that's good enough, so LGTM
fabpot
approved these changes
Mar 3, 2025
6a726fa to
791e814
Compare
Member
|
Thank you @wuchen90. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For those who doesn't want the package.json synchronization, this PR offers to opt-out this behavior by setting the config below in extra section of composer.json:
{ "extra": { "symfony/flex": { "synchronize_package_json": false } } }fix #1017