[wallet/desktop] fix: offline transaction - fill information about av…#1981
Merged
cryptoBeliever merged 4 commits intodevfrom May 22, 2023
Merged
[wallet/desktop] fix: offline transaction - fill information about av…#1981cryptoBeliever merged 4 commits intodevfrom
cryptoBeliever merged 4 commits intodevfrom
Conversation
…ailable plugins for mainnet and testnet
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1981 +/- ##
==========================================
+ Coverage 53.64% 53.76% +0.11%
==========================================
Files 584 585 +1
Lines 14006 14029 +23
Branches 2348 2351 +3
==========================================
+ Hits 7513 7542 +29
+ Misses 6443 6437 -6
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AnthonyLaw
reviewed
Apr 25, 2023
AnthonyLaw
reviewed
Apr 25, 2023
Member
|
can you add a unit test to ensure the offline transaction deadline is generated correctly. |
…ailable plugins for mainnet and testnet
…ailable plugins for mainnet and testnet - test
AnthonyLaw
reviewed
Apr 27, 2023
…ailable plugins for mainnet and testnet - test
AnthonyLaw
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue?
The problem described in #1980
Method NetworkConfigurationHelpers.epochAdjustment (and others helper in this file) expected available plugins config to be present in network configuration. For offline transaction this has been not filled. Because of that wallet used epoch adjustment for the default network (testnet).
What's the fix?
Fill in information about plugins for offline configuration