Skip to content

[wallet/desktop] task: add information about mosaic revokable flag#1971

Merged
cryptoBeliever merged 2 commits intodevfrom
feature/mosaic-add-information-about-mosaic-revokable-flag
Jan 31, 2023
Merged

[wallet/desktop] task: add information about mosaic revokable flag#1971
cryptoBeliever merged 2 commits intodevfrom
feature/mosaic-add-information-about-mosaic-revokable-flag

Conversation

@cryptoBeliever
Copy link
Contributor

Current behavior

The mosaic revokable flag is not presented on the mosaics list and in the mosaic definition transaction details:
#1966

What's the improvement?

Show the mosaic revokable flag on the mosaics list and in the mosaic definition transaction details.

image
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1971 (7378ef3) into dev (51fe6ae) will increase coverage by 0.08%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1971      +/-   ##
==========================================
+ Coverage   53.64%   53.72%   +0.08%     
==========================================
  Files         584      585       +1     
  Lines       14006    14018      +12     
  Branches     2348     2351       +3     
==========================================
+ Hits         7513     7531      +18     
+ Misses       6443     6437       -6     
  Partials       50       50              
Flag Coverage Δ
wallet-desktop 53.72% <86.66%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/transactions/ViewMosaicDefinitionTransaction.ts 100.00% <ø> (+81.81%) ⬆️
...c/services/AssetTableService/MosaicTableService.ts 100.00% <ø> (ø)
src/views/resources/Images.ts 100.00% <ø> (ø)
src/core/transactions/TransactionViewFactory.ts 58.44% <33.33%> (-1.02%) ⬇️
src/core/database/entities/MosaicModel.ts 100.00% <100.00%> (ø)
...nsactions/ViewMosaicSupplyRevocationTransaction.ts 100.00% <100.00%> (ø)
src/core/utils/TimeHelpers.ts 68.75% <0.00%> (-1.05%) ⬇️

Copy link
Member

@AnthonyLaw AnthonyLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!! 👍🏼

@cryptoBeliever cryptoBeliever merged commit 8d38292 into dev Jan 31, 2023
@cryptoBeliever cryptoBeliever deleted the feature/mosaic-add-information-about-mosaic-revokable-flag branch January 31, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants