fix: preserve rolldown resolution if an id is externalized#213
Merged
fix: preserve rolldown resolution if an id is externalized#213
Conversation
sxzz
approved these changes
Mar 25, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Something like this doesn't work properly in tsdown currently:
It works for the JS part, like if
src/foo/bar.tshasimport {} from '../../shared', then the compileddist/foo/index.jshas../shared.js, but the DTS part is left with../../shared.(I know this example is simple enough to be specified via external/deps.neverBundle, but the real use case has less simple logic.)
Earlier code kept the
idunchanged for dts files since it returned it's ownexternalobject instead of respecting otherresolveIdhooks in the chain.Linked Issues
Additional context