fix: exclude rolldown runtime from transform hook#178
Merged
Conversation
sxzz
approved these changes
Feb 1, 2026
commit: |
After rolldown/rolldown#8093, rolldown exposes the runtime module (`\0rolldown/runtime.js`) to the transform hook. The `rolldown-plugin-dts` transform hook transforms all JavaScript files to `"export { };"` when `emitDtsOnly: true`, which removes the runtime helpers like `__exportAll`, causing rolldown to panic. This commit adds a constant for the rolldown runtime module pattern and uses it in the transform filter's exclude list. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cc5703e to
18abbcc
Compare
|
Can confirm that the vite test panic is fixed with this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After rolldown/rolldown#8093, rolldown exposes the runtime module (
\0rolldown/runtime.js) to the transform hook. Therolldown-plugin-dtstransform hook transforms all JavaScript files to"export { };"whenemitDtsOnly: true, which removes the runtime helpers like__exportAll, causing rolldown to panic:This PR adds a constant for the rolldown runtime module pattern and uses it in the transform filter's exclude list to specifically exclude the rolldown runtime module which should not be transformed.
Test plan
pnpm buildpackages/vite/package.jsonto point to the local buildpnpm buildin vite repo - succeeds without panicking🤖 Generated with Claude Code