Fix building on FreeBSD via cmake#925
Merged
Merged
Conversation
Contributor
|
I assume you've tested this? |
Contributor
|
@swift-ci test |
Member
Author
yup, I compiled a toolchain with the change and tested on a random swift project (in this case, swift-crypto) and verified swift-testing is loading. |
grynspan
approved these changes
Jan 25, 2025
Contributor
|
We obviously don't have any CI set up for FreeBSD, but please wait until the CI we do have is done before merging. |
grynspan
requested changes
Jan 25, 2025
grynspan
approved these changes
Jan 26, 2025
Contributor
|
@swift-ci test |
Contributor
|
Feel free to merge once CI is green—if you don't have the Big Green Button yet, send me a DM and I'll do it. |
Contributor
|
@swift-ci test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently building swift-testing via cmake (e.g. when building the toolchain) fail if not compile as PIC. Adding "-fPIC" fixed this problem. Moreover, we need to link against
libexecinfoon FreeBSD where the symbolbacktracelives.Result:
Swift testing can now successfully build via cmake thus installed to the toolchain 🥳