Add support for raw identifiers.#887
Merged
Merged
Conversation
Contributor
Author
|
@allevato, would you mind reviewing please? |
grynspan
commented
Jan 4, 2025
Contributor
Author
|
@swift-ci test |
allevato
reviewed
Jan 6, 2025
Contributor
Author
|
@swift-ci test |
allevato
approved these changes
Jan 6, 2025
allevato
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks! Excited to use this once the feature itself lands.
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
briancroom
approved these changes
Jan 7, 2025
stmontgomery
reviewed
Jan 7, 2025
stmontgomery
reviewed
Jan 7, 2025
This PR adds support for the raw identifiers feature introduced with [SE-0451](https://forums.swift.org/t/accepted-with-revision-se-0451-raw-identifiers/76387). At this time, I _think_ I don't need to make any changes to our macro expansion code for it to compile and run, however I may need to revisit later in order to treat functions with raw identifiers as having "display names" and to synthesize test IDs for them that are concise (CRC-32 to the rescue?) We'll cross that bridge when we come to it, after the feature has landed in the toolchain. Resolves #842.
… explicit display name string literals
Contributor
Author
|
@swift-ci test |
db5c06a to
11ef9ff
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the raw identifiers feature introduced with SE-0451.
Resolves #842.
Checklist: