Simplify the logic for parsing and handling test arguments in the @Test macro#834
Merged
stmontgomery merged 2 commits intoDec 10, 2024
Merged
Conversation
7460fce to
77c469b
Compare
Contributor
Author
|
@swift-ci please test |
2 tasks
grynspan
reviewed
Dec 10, 2024
grynspan
approved these changes
Dec 10, 2024
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor refactor of the logic and data structures in the
@Testmacro implementation responsible for parsing and handling test function argument expressions.Motivation:
I discovered there was a way to simplify this logic while working on #808, and since this isn't strictly pertinent to that PR I wanted to extract it and land it separately here.
Modifications:
arguments:in three places.Checklist: