Skip to content

Change archive format for directories to .zip and add iOS/etc. support.#826

Merged
grynspan merged 4 commits into
mainfrom
jgrynspan/zip-directories
Dec 6, 2024
Merged

Change archive format for directories to .zip and add iOS/etc. support.#826
grynspan merged 4 commits into
mainfrom
jgrynspan/zip-directories

Conversation

@grynspan

@grynspan grynspan commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

This PR switches from .tar.gz as the preferred archive format for compressed directories to .zip and uses NSFileCoordinator on Darwin to enable support for iOS, watchOS, tvOS, and visionOS.

This feature remains experimental.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added enhancement New feature or request attachments/activities 🖇️ Work related to attachments and/or activities labels Nov 15, 2024
@grynspan grynspan added this to the Swift 6.1 milestone Nov 15, 2024
@grynspan grynspan self-assigned this Nov 15, 2024
@grynspan

Copy link
Copy Markdown
Contributor Author

@kperryua I can't add you as a reviewer for whatever reason. Hi.

Comment thread Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift Outdated

@compnerd compnerd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly reasonable - except for this spawning processes under SWT_NO_PROCESS_SPAWNING 😂

@grynspan

Copy link
Copy Markdown
Contributor Author

Seems mostly reasonable - except for this spawning processes under SWT_NO_PROCESS_SPAWNING 😂

As discussed elsewhere, there's a ! in there.

@grynspan

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@grynspan grynspan modified the milestones: Swift 6.1, Swift 6.2 Nov 19, 2024
@grynspan grynspan force-pushed the jgrynspan/zip-directories branch from d7ca88f to 708811a Compare November 21, 2024 16:14
@grynspan

Copy link
Copy Markdown
Contributor Author

@swift-ci test

This PR switches from .tar.gz as the preferred archive format for compressed
directories to .zip and uses `NSFileCoordinator` on Darwin to enable support for
iOS, watchOS, tvOS, and visionOS.
@grynspan grynspan force-pushed the jgrynspan/zip-directories branch from 708811a to 6cebbed Compare December 5, 2024 22:28
@grynspan

grynspan commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

@swift-ci test

Comment thread Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift Outdated
@grynspan

grynspan commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@grynspan grynspan merged commit a4ed760 into main Dec 6, 2024
@grynspan grynspan deleted the jgrynspan/zip-directories branch December 6, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attachments/activities 🖇️ Work related to attachments and/or activities enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants