Update docs for decoding stdout and stderr from exit tests#1230
Merged
stmontgomery merged 1 commit intoJul 17, 2025
Merged
Conversation
stmontgomery
approved these changes
Jul 17, 2025
stmontgomery
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Makes sense to me, but I'll let @grynspan weigh in first
grynspan
approved these changes
Jul 17, 2025
grynspan
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me. I think I originally wrote this documentation before that initializer was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The API documentation for
ExitTest.Result.standardOutputContentandExitTest.Result.standardErrorContenthas advice on how to construct a string from their contents. It recommends usingString.init(validatingCString:), which has two problems:[UInt8]andString.init(validatingCString:)takes sequences whose element isCChar(akaInt8):So, in order to get this working without warnings, adopters will likely want this:
Modifications:
Checklist:
If public symbols are renamed or modified, DocC references should be updated.