Simplify NSImageRep-checking logic to use Bundle.#1217
Merged
Conversation
This PR simplifies the logic we use to check if subclasses of `NSImageRep` are likely to be thread-safe by using Foundation's `Bundle` instead of querying dyld. AppKit always links Foundation, so there's no need for us to roll our own logic for this check.
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic we use to check if subclasses of
NSImageRepare likely to be thread-safe by using Foundation'sBundleinstead of querying dyld. AppKit always links Foundation, so there's no need for us to roll our own logic for this check.Checklist: