Skip to content

IssueHandlingTrait refinements: Rename to 'compactMapIssues' and special-case system issues#1136

Merged
stmontgomery merged 3 commits into
swiftlang:mainfrom
stmontgomery:issue-handling-trait-pitch-feedback
Jun 7, 2025
Merged

IssueHandlingTrait refinements: Rename to 'compactMapIssues' and special-case system issues#1136
stmontgomery merged 3 commits into
swiftlang:mainfrom
stmontgomery:issue-handling-trait-pitch-feedback

Conversation

@stmontgomery

@stmontgomery stmontgomery commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refinements to IssueHandlingTrait based on pitch feedback.

Modifications:

  • Rename the transformIssues(_:) function to compactMapIssues(_:) to align better with filterIssues(_:).
  • Ignore issues for which the value of kind is .system.
  • Prohibit returning an issue from the closure passed to compactMapIssues(_:) whose kind is .system.
  • Adjust documentation and tests.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added this to the Swift 6.x milestone Jun 4, 2025
@stmontgomery stmontgomery self-assigned this Jun 4, 2025
@stmontgomery stmontgomery added enhancement New feature or request issue-handling Related to Issue handling within the testing library traits Issues and PRs related to the trait subsystem or built-in traits labels Jun 4, 2025
@stmontgomery stmontgomery changed the title IssueHandlineTrait refinements: Rename to compactMapIssues(_:) and ignore system issues IssueHandlingTrait refinements: Rename to 'compactMapIssues' and special-case system issues Jun 4, 2025
@stmontgomery

stmontgomery commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@stmontgomery

stmontgomery commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci please test macOS

@xedin xedin mentioned this pull request Jun 5, 2025
Merged
@stmontgomery

stmontgomery commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci please test macOS

@stmontgomery stmontgomery merged commit edb9a6a into swiftlang:main Jun 7, 2025
3 checks passed
@stmontgomery stmontgomery deleted the issue-handling-trait-pitch-feedback branch June 7, 2025 11:46
@stmontgomery stmontgomery modified the milestones: Swift 6.x, Swift 6.2 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzannaratcliff suzannaratcliff suzannaratcliff approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

Assignees

@stmontgomery stmontgomery

Labels

enhancement New feature or request issue-handling Related to Issue handling within the testing library traits Issues and PRs related to the trait subsystem or built-in traits

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stmontgomery @suzannaratcliff