Add support for body macros on variables and accessors#3298
Merged
rintaro merged 7 commits intoswiftlang:mainfrom Mar 20, 2026
Merged
Add support for body macros on variables and accessors#3298rintaro merged 7 commits intoswiftlang:mainfrom
rintaro merged 7 commits intoswiftlang:mainfrom
Conversation
calda
commented
Mar 15, 2026
calda
commented
Mar 15, 2026
rintaro
reviewed
Mar 17, 2026
rintaro
reviewed
Mar 17, 2026
Member
|
@swift-ci Please test |
rintaro
reviewed
Mar 18, 2026
Member
|
@swift-ci Please test |
rintaro
approved these changes
Mar 20, 2026
Member
|
@swift-ci Please test Windows |
Member
|
Thank you Cal! |
Contributor
Author
|
Thanks for the review and support 🙇🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding compiler PR: swiftlang/swift#87869
According to SE-0415, body macros should be supported on variables and accessors:
However, both forms are currently unsupported with errors like
error: 'body' macro cannot be attached to var ('area')orerror: Declaration is not a type with an optional code block.This PR adds implements supports for both of these use cases.
AccessorDeclSyntaxreceived via a plugin message.VariableDeclSyntax, and then within Swift Syntax synthesize an implicitAccessorDeclSyntaxto use in theexpansion(of:providingBodyFor:in:)call (which needs aWithOptionalCodeBlockSyntax).At Airbnb, we'd like to use this functionality to enable adding instrumentation to SwiftUI view bodies, like:
Fixes swiftlang/swift#75715.
Please review: @ahoppen @DougGregor