Update SE-0365 to discuss source compatibility implications#1819
Closed
calda wants to merge 1 commit intoswiftlang:mainfrom
Closed
Update SE-0365 to discuss source compatibility implications#1819calda wants to merge 1 commit intoswiftlang:mainfrom
calda wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
This is a follow-up to the discussion here: swiftlang/swift#61520 (comment) |
Contributor
Author
|
Closing since we found an approach for implementing this in Swift 5 mode: swiftlang/swift#61520 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates SE-0365 to discuss its implications for source compatibility.
When landing the implementation, we discovered that it's actually source-breaking. This is because there is a bug in Swift 5.7 where implicit self is unexpectedly permitted in non-escaping closures that capture self weakly. This means that this proposal is source-breaking, and can't be enabled until Swift 6. The proposal body now discusses this, and defines changes that will made in Swift 5 mode in preparation for a source-break in Swift 6.