AST: don't propagate null Type from invalid associated conformance #88873
Merged
airspeedswift merged 1 commit intoMay 7, 2026
Conversation
Member
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
May 6, 2026
Contributor
|
I would prefer check the conformance first, like We should probably fix the representation of invalid conformances to store a type at some point (today the invalid conformance is a singleton, literally a null pointer), since this sort of workaround has come up in several places already. |
8dade2c to
5f5e499
Compare
Member
Author
|
@swift-ci please smoke test |
… PackConformance::getAssociatedConformance When a pattern conformance in the pack is invalid (e.g. its underlying conformance failed because of a prior diagnostic), `getAssociatedConformance` returned an invalid `ProtocolConformanceRef` whose `getType()` is null. The null type was pushed into `packElements` and tripped an assertion in `PackType::get`. Substitute `ErrorType` for the null so substitution can complete and the existing diagnostics surface to the user. Fixes swiftlang#88434.
5f5e499 to
9cd64d1
Compare
Member
Author
|
@swift-ci please smoke test |
Member
Author
Filed #88902 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pattern conformance in the pack is invalid (e.g. its underlying conformance failed because of a prior diagnostic),
getAssociatedConformancereturned an invalidProtocolConformanceRefwhosegetType()is null. The null type was pushed intopackElementsand tripped an assertion inPackType::get. SubstituteErrorTypefor the null so substitution can complete and the existing diagnostics surface to the user.Fixes #88434.