[CSSimplify] Handle situations when generic argument mismatch happens…#88493
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
… in a synthesized argument If the argument was synthesized by the solver, let's fail. This can happen when a parameter type is optional and (currently) inference would try both optional and non-optional bindings for the new argument which cases a mismatch in one of the conversion cases. Resolves: swiftlang#88456 Resolves: rdar://174723056
Contributor
Author
|
@swift-ci please test |
hamishknight
approved these changes
Apr 16, 2026
Contributor
Author
|
macOS arm64 failure is unrelated and happens in other PRs as well - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in a synthesized argument
Explanation:
If the argument was synthesized by the solver, let's fail. This can happen when a parameter type is optional and (currently) inference would try both optional and non-optional bindings for the new argument which cases a mismatch in one of the conversion cases.
Scope:
Invalid calls where some of the arguments are missing and parameters are generic in some way that would make solver attempt multiple different bindings i.e. optional type.
Issues:
Resolves: [Swift] Assertion "Expected non-null node" in ConstraintSystem::getType when type-checking a @Sendable closure calling an overloaded @preconcurrency @MainActor function shadowed by a global var binding #88456
Resolves: rdar://174723056
Risk:
Very low. Replaces an assertion with a graceful failure.
Testing:
Resolved a few existing crashers and added a new test-case into the validation suite.
Reviewers:
@hamishknight