[6.3.1][Test] Disable macro_swiftdeps.swift test case#88411
Merged
shahmishal merged 1 commit intoApr 10, 2026
Conversation
This test may fail in Windows because of the bug in libMockPlugin where it doesn't set `_O_BINARY` to stdio. Disable the test while fixing it. rdar://174235365
Member
Author
|
@swift-ci Please test |
This was referenced Apr 10, 2026
This was referenced Apr 10, 2026
bb6cffd to
0f81e94
Compare
Member
Author
|
@swift-ci Please test macOS |
Contributor
|
@swift-ci please test |
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
macro_swiftdeps.swifttest may fail in Windows because of the bug inlibMockPluginwhere it doesn't set_O_BINARYto stdio. If a binary plugin message happens to contain0x1A, it's considered as an EOF, and the plugin exits, causing a test failure. Disable the test.Scope: Macro plugin testing
Risk: Low. Just disabling the test case. It's testing a feature that is well tested in
release/6.3. Andrelease/6.3.1doesn't have any changes around the feature.Issue: rdar://174235365
Testing: Passed the current test suite
Reviewer: TBA