Skip to content

Reenable build of compiler-rt with LLVM_ENABLE_RUNTIMES in Linux bots...#81386

Merged
edymtt merged 2 commits intoswiftlang:mainfrom
edymtt:edymtt/do-not-crosscompile-llvm-under-linux
May 14, 2025
Merged

Reenable build of compiler-rt with LLVM_ENABLE_RUNTIMES in Linux bots...#81386
edymtt merged 2 commits intoswiftlang:mainfrom
edymtt:edymtt/do-not-crosscompile-llvm-under-linux

Conversation

@edymtt
Copy link
Copy Markdown
Contributor

@edymtt edymtt commented May 8, 2025 •
edited
Loading

...we disabled in #81354

This requires a couple of supporting changes

  • under Linux, do not cross compile LLVM when building for the host
    architecture -- that will ensure that the compiler-rt build will use
    the just built compiler and not the system one (which may not be
    new enough for this purpose);
  • provide sanitizer flags depending on the linker the just built compiler
    will use -- this detection is brittle, so print a message advising the
    user how to override this.

Addresses rdar://150849329

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 24.04 aarch64

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2 aarch64

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt edymtt force-pushed the edymtt/do-not-crosscompile-llvm-under-linux branch from 1a797a0 to ff1c471 Compare May 9, 2025 16:22
@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

@swift-ci please smoke test

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

Please test with following pull request:
swiftlang/swift-package-manager#8647

@swift-ci please build toolchain Amazon Linux 2

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 9, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt edymtt marked this pull request as ready for review May 9, 2025 16:37
@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 12, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 12, 2025

@swift-ci please build toolchain Amazon Linux 2

edymtt
edymtt commented May 13, 2025
View reviewed changes
@edymtt
Reenable build of compiler-rt with LLVM_ENABLE_RUNTIMES in Linux bots...
fcc0389 
...we disabled in swiftlang#81354

This requires a couple of supporting changes

* under Linux, do not cross compile LLVM when building for the host
 architecture -- that will ensure that the compiler-rt build will use
the just built compiler and not the system one (which may not be
new enough for this purpose);
* provide sanitizer flags depending on the linker the just built compiler
 will use -- this detection is brittle, so print a message advising the
user how to override this.

Addresses rdar://150849329
@edymtt edymtt force-pushed the edymtt/do-not-crosscompile-llvm-under-linux branch from ff1c471 to fcc0389 Compare May 13, 2025 16:14
@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please smoke test

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain macOS

@edymtt
Copy link
Copy Markdown
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt edymtt merged commit a5261ae into swiftlang:main May 14, 2025
10 checks passed
@finagolfin finagolfin mentioned this pull request Aug 2, 2025
Merged
@finagolfin finagolfin mentioned this pull request Aug 19, 2025
Merged
@finagolfin finagolfin mentioned this pull request Sep 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etcwilde etcwilde Awaiting requested review from etcwilde

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edymtt