Propagate sysroot to module loader subinvocation#80007
Merged
hjyamauchi merged 1 commit intoswiftlang:mainfrom Mar 15, 2025
Merged
Propagate sysroot to module loader subinvocation#80007hjyamauchi merged 1 commit intoswiftlang:mainfrom
hjyamauchi merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
Contributor
Author
|
This is an alternative to #79840 |
compnerd
reviewed
Mar 14, 2025
To fix the Android build issue swiftlang#79839
47e2c82 to
1a3a6e1
Compare
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Mar 14, 2025
Member
compnerd
left a comment
There was a problem hiding this comment.
Passing along the sysroot to the module loading seems like the right thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the Android build issue #79839