[FreeBSD] Adding FreeBSD support by michael-yuji · Pull Request #77836 · swiftlang/swift

michael-yuji · 2024-11-25T22:53:38Z

This commit adds required conditional compilation blocks to enable building and running
on FreeBSD (tested on x86_64 FreeBSD 14.1-RELEASE-p6).

Also implements FreeBSD synchronization shims using _umtx_op(2)

lin72h · 2024-11-25T22:57:51Z

It's my early Christmas gift. Thanks for working on this.

michael-yuji · 2024-11-26T01:04:52Z

It's my early Christmas gift. Thanks for working on this.

unfortunately this PR alone here is not enough. I do have patches to other swift components to get it fully working and going to PR them to coming weeks. But even with those, you'll need to have a functional swiftc (by bootstrapping a swift 5.8+) on FreeBSD to build them. personally I've done a multi-stages bootstrap until I now have a toolchain ready.

you also need a patch to the base libc++ to workaround this issue

lin72h · 2024-11-26T01:34:18Z

it's very impressive work especially the bootstrap part!

finagolfin · 2024-11-26T13:02:35Z

Nice, there is some work to get Swift 6 bootstrapping again, #77815, that you'll want to follow.

Pinging @mhjacobson and @3405691582, who added BSD support before and may be able to help review.

3405691582 · 2024-11-30T20:57:00Z

As a heads up, the code uses LLVM target triples and the build system has a few places where it assumes that the platform calls the architecture with the same name as LLVM does. This isn't a problem for FreeBSD on what LLVM calls x86_64, since they apparently both seem to use the same spelling, but for what LLVM calls aarch64, both OpenBSD and FreeBSD call it arm64. This causes headaches.

In the past, I've tried to keep some meaningful separation between platform spelling and LLVM spelling, but I'm reconsidering that in #77879. You probably won't need to do anything right now for this pr if you're just targeting x86_64, though, and what you have seems good to me, but keep this in mind if you're going to also be working on arm64.

khng300 · 2024-12-01T20:57:16Z

As a heads up, the code uses LLVM target triples and the build system has a few places where it assumes that the platform calls the architecture with the same name as LLVM does. This isn't a problem for FreeBSD on what LLVM calls x86_64, since they apparently both seem to use the same spelling, but for what LLVM calls aarch64, both OpenBSD and FreeBSD call it arm64. This causes headaches.

In the past, I've tried to keep some meaningful separation between platform spelling and LLVM spelling, but I'm reconsidering that in #77879. You probably won't need to do anything right now for this pr if you're just targeting x86_64, though, and what you have seems good to me, but keep this in mind if you're going to also be working on arm64.

Which is not correct for the FreeBSD part. On FreeBSD itself, arm64 is the TARGET, meanwhile aarch64 is the TARGET_ARCH and MACHINE_ARCH. Below is what I got from a build of the FreeBSD tree on my side:

CMD cc -target aarch64-unknown-freebsd15.0 --sysroot=

For reference how we build the -target tuple in the tree:

Makefile.inc1:		MACHINE_ARCH=${TARGET_ARCH}
Makefile:	TARGET=${_TARGET} TARGET_ARCH=${_TARGET_ARCH} ${_MAKEARGS}
Makefile:_TARGET_ARCH=	${TARGET:S/arm64/aarch64/:S/riscv/riscv64/:S/arm/armv7/}
./Makefile.inc1:MACHINE_TRIPLE?=${MACHINE_ARCH:S/amd64/x86_64/}-${MACHINE_TRIPLE_ABI}-freebsd${OS_REVISION}

michael-yuji · 2024-12-02T18:48:55Z

@swift-ci please smoke test

michael-yuji · 2024-12-03T17:56:03Z

@swift-ci please test

CodingCarpincho · 2025-05-29T06:32:36Z

@shahmishal Could you or someone else kick off the CI here so we can get Michael’s work merged?

3405691582 · 2025-05-29T06:49:59Z

@swift-ci please test.

… and trivial copy ctor is yet available even on 14

michael-yuji · 2025-06-02T17:47:47Z

@swift-ci please test

…eebsd

etcwilde · 2025-06-17T21:19:31Z

@swift-ci please test

michael-yuji · 2025-06-18T17:48:06Z

@swift-ci please test windows

etcwilde · 2025-06-18T17:53:32Z

macOS test failure is a regression brought in by #82275.

etcwilde · 2025-06-18T17:58:33Z

#82329 landed with a fix.

etcwilde · 2025-06-18T17:58:42Z

@swift-ci please test macOS

michael-yuji requested a review from a team as a code owner November 25, 2024 22:53

compnerd reviewed Nov 26, 2024

View reviewed changes

Comment thread stdlib/public/Platform/SwiftGlibc.h.gyb

michael-yuji requested review from QuietMisdreavus, Xazax-hun, ahoppen, beccadax, bnbarham, eeckstein, egorzhdan, hamishknight, hborla, hyp, ian-twilightcoder, rintaro, rjmccall, slavapestov, xedin and zoecarver as code owners November 29, 2024 01:04

QuietMisdreavus removed their request for review December 2, 2024 17:47

ahoppen removed their request for review December 3, 2024 22:21

grynspan mentioned this pull request Dec 18, 2024

Additional FreeBSD fixes swiftlang/swift-testing#865

Merged

2 tasks

michael-yuji force-pushed the mchiu/freebsd branch from 8c4f0d4 to 65db70b Compare January 26, 2025 09:16

Merge branch 'main' into mchiu/freebsd

9a948a9

michael-yuji requested review from etcwilde, hnrklssn, justice-adams-apple and shahmishal as code owners May 21, 2025 23:29

CodingCarpincho approved these changes May 22, 2025

View reviewed changes

Comment thread cmake/modules/SwiftConfigureSDK.cmake Outdated

Comment thread include/swift/AST/AutoDiff.h Outdated

Merge branch 'main' into mchiu/freebsd

8738e72

jrtc27 reviewed May 29, 2025

View reviewed changes

Comment thread include/swift/AST/AutoDiff.h Outdated

jrtc27 reviewed May 29, 2025

View reviewed changes

Comment thread include/swift/SILOptimizer/Differentiation/DifferentiationInvoker.h Outdated

jrtc27 reviewed May 29, 2025

View reviewed changes

Comment thread stdlib/public/core/CTypes.swift Outdated

jrtc27 reviewed May 29, 2025

View reviewed changes

Comment thread stdlib/public/runtime/CMakeLists.txt Outdated

michael-yuji added 2 commits June 2, 2025 13:33

Merge branch 'main' into mchiu/freebsd

7bbafc5

CLongDouble should map to Float128 (which is yet supported) on arm64,…

84ee0af

… and trivial copy ctor is yet available even on 14

michael-yuji added 4 commits June 17, 2025 15:12

Merge commit '665515c781999a81094bbe4f8302a7cb1a6a6b39' into mchiu/fr…

d681126

…eebsd

address pltaform orders and other nits

cf041b1

Merge branch 'main' into mchiu/freebsd

aaf2832

removed duplicated

bc870ef

etcwilde approved these changes Jun 17, 2025

View reviewed changes

michael-yuji enabled auto-merge June 17, 2025 21:48

michael-yuji merged commit cf2f715 into swiftlang:main Jun 19, 2025
4 of 5 checks passed

github-project-automation Bot moved this from In Progress to Done in Swift on FreeBSD Jun 19, 2025

etcwilde mentioned this pull request Aug 2, 2025

🍒6.2: Grabbing missing changes on main for FreeBSD support #83500

Draft

Conversation

michael-yuji commented Nov 25, 2024

Uh oh!

lin72h commented Nov 25, 2024

Uh oh!

michael-yuji commented Nov 26, 2024

Uh oh!

lin72h commented Nov 26, 2024

Uh oh!

Uh oh!

finagolfin commented Nov 26, 2024

Uh oh!

3405691582 commented Nov 30, 2024

Uh oh!

khng300 commented Dec 1, 2024

Uh oh!

michael-yuji commented Dec 2, 2024

Uh oh!

michael-yuji commented Dec 3, 2024

Uh oh!

Uh oh!

Uh oh!

CodingCarpincho commented May 29, 2025

Uh oh!

3405691582 commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michael-yuji commented Jun 2, 2025

Uh oh!

etcwilde commented Jun 17, 2025

Uh oh!

michael-yuji commented Jun 18, 2025

Uh oh!

etcwilde commented Jun 18, 2025

Uh oh!

etcwilde commented Jun 18, 2025

Uh oh!

etcwilde commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants