Sema: Diagnose global actor attribute access and availability#60672
Merged
tshortli merged 3 commits intoswiftlang:mainfrom Aug 24, 2022
Merged
Sema: Diagnose global actor attribute access and availability#60672tshortli merged 3 commits intoswiftlang:mainfrom
tshortli merged 3 commits intoswiftlang:mainfrom
Conversation
…ation is inconsistent with the access level of the declaration. Resolves rdar://98200658 and swiftlang#60420.
…`@usableFromInline` declarations.
…udes SPI and resilience diagnostics.
2282bba to
c13dd18
Compare
Contributor
Author
|
@swift-ci please test |
tshortli
commented
Aug 22, 2022
|
|
||
| @available(SwiftStdlib 5.1, *) | ||
| @inlinable public func testNestedFuncs() { | ||
| // FIXME: Functions isolated to non-resilient global actors nested in |
Contributor
Author
There was a problem hiding this comment.
I'd like to defer addressing these test cases to a follow up. In my testing it seems that we failed to diagnose these inline function decls because their global actor CustomAttrs are not yet bound to a type when the availability checker runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When visiting declarations in the availability and accessibility checkers, check the global actor attribute of the declaration, too. Failing to do so allows module authors to construct broken APIs involving global actors.
Resolves: #60420 and rdar://98200658